[tor-bugs] #10088 [Tor]: Shutdown tor helpers properly with CREATE_BREAKAWAY_FROM_JOB (?)

[Tor Bug Tracker & Wiki]

#10088: Shutdown tor helpers properly with CREATE_BREAKAWAY_FROM_JOB (?)
--------------------+------------------------------------
 Reporter:  asn     |          Owner:
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor     |        Version:
 Keywords:  tor-pt  |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 While building Windows pbfs-flash PTTB bundles, we encountered an issue
 where the obfsproxy child of obfs-flash would not be terminated properly
 after closing the PTTBB. More information can be found in
 comment:5:ticket:10006 .

 After lots of digging around, the problem was solved by toggling the
 `CREATE_BREAKAWAY_FROM_JOB` flag of `CreateProcess()` in
 `tor_spawn_background()`. More info in comment:26:ticket:10006.

 We should look at the possible side-effects of adding the
 `CREATE_BREAKAWAY_FROM_JOB` flag there, and if it's innocuous then we
 should implement the change and get it merged.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10088>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online