[tor-bugs] #8692 [Stem]: ONLINE integ target fails

[Tor Bug Tracker & Wiki]

#8692: ONLINE integ target fails
--------------------------+-------------------------------------------------
 Reporter:  atagar        |          Owner:  atagar      
     Type:  defect        |         Status:  needs_review
 Priority:  minor         |      Milestone:              
Component:  Stem          |        Version:              
 Keywords:  testing easy  |         Parent:              
   Points:                |   Actualpoints:              
--------------------------+-------------------------------------------------
Changes (by saturn597):

 * cc: saturn5971@… (added)
  * status:  new => needs_review


Comment:

 Here's a patch that might help:

 https://github.com/saturn597/stem/commit/a6ee8821597f9c615b32965d87b9d108d94debbb

 I modified test_attachstream and test_mapaddress to repeat their network-
 reliant parts a few times if they fail, in order to rule out the
 possibility that we're failing only due to temporary network issues. I
 also changed the strategy in attachstream a bit so that it doesn't depend
 on checking our IP address to determine whether we attached to the right
 circuit, since sometimes the address Tor reports for an exit is different
 from what it actually turns out to be.

 With these changes, the online target fails pretty rarely, though I still
 get exceptions due to test_closestream having streams open at the end. The
 extra streams I've seen are for a DIR_FETCH. The test probably only needs
 to make sure that it ends the stream it started, rather than trying to
 ensure that there are no more streams.  I'll plan to check it out more
 later, though nobody else should be dissuaded from tackling it in case I
 don't. :) Just wanted to submit the other patches now.

 Thank you!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8692#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online