[tor-bugs] #6752 [Tor]: TestingTorNetwork doesn't lower the dir fetch retry schedules

[Tor Bug Tracker & Wiki]

#6752: TestingTorNetwork doesn't lower the dir fetch retry schedules
--------------------------------------+-------------------------------------
 Reporter:  arma                      |          Owner:                    
     Type:  enhancement               |         Status:  needs_revision    
 Priority:  major                     |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                       |        Version:                    
 Keywords:  tor-client small-feature  |         Parent:  #7172             
   Points:                            |   Actualpoints:                    
--------------------------------------+-------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Looks good; i want to get this in.

 Quick review:
  * The documentation for smartlist_ints_eq needs to say that the
 smartlists are lists of pointer to int.
  * There is a huge new amount of boilerplate copy-and-paste code in
 options_validate().  Please use macros or functions to avoid piles of
 duplicated code?
  * You added a new argument to options_validate but didn't document how it
 works.
  * Prefer smartlist_add_asprintf() to tor_asprintf(); smartlist_add().
  * find_dl_schedule_and_len should document its arguments and return
 types. (Yes, I know it didn't before, but it should.)
  * Shouldn't find_dl_schedule return a const smartlist_* ?
  * It's weird that this function accesses Testing* options, but it's
 always used regardless of whether we're running in testing mode or not.  I
 don't much like having Testing* mean "a variable that you can only change
 when Testing* is on, but which is used in all cases."  Can we come up with
 some better way to do this?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6752#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online