[tor-bugs] #8932 [Compass]: Add support for grouping by network family

[Tor Bug Tracker & Wiki]

#8932: Add support for grouping by network family
-------------------------+--------------------------------------------------
 Reporter:  lunar        |          Owner:  gsathya       
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Compass      |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by karsten):

  * status:  needs_review => needs_revision


Comment:

 I like the idea.  But the patches need some tweaking:

  - When I try out the `-N` option without the ipaddr module, I get:
 `NameError: name 'LoadError' is not defined`

  - Nickname is not the right column to put in the /16 network.  Should we
 add an IP address column?  It could by default list the IP address that
 the relay used to register in the network, that is, the first entry in
 or_addresses.  (Speaking of, I should guarantee in the Onionoo protocol
 specification that the first entry is always that primary IP address, not
 some other additional OR address.  If you think that makes sense, I'll
 make the change.)

  - The `-N` option doesn't work together with the `-A` and/or `-C`
 options.  Should these combinations be allowed?  If not, their combined
 usage should be prohibited.  It would be easier though to allow these
 combinations, also with respect to the web version.

  - We should only look at the primary IP address of a relay for /16
 comparison.  That's what tor does, too.  Also, once a relay is in more
 than one /16 network, it would be contained in more than one group, which
 is not allowed.  The effect would be that Compass shows in total more
 relays, more CW, more adv_bw, etc. than there are in the network.  This
 means that your first patch is not required, because the grouping function
 can only return a single group per relay.  For example, if the `-N` option
 is used together with `-A` and `-C`, that group would be a tuple `('AS
 123', 'DE', '4.5.0.0/16')`.

 Do these suggestions make sense to you?  Do you want to tweak the patch?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8932#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online