[tor-bugs] #8879 [Tor]: pidgin fails to do socks5 handshake with username/password auth

[Tor Bug Tracker & Wiki]

#8879: pidgin fails to do socks5 handshake with username/password auth
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-client  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 Actually! I think this might be Tor's fault, yes?

 Here's what the wikipedia socks page says:
 {{{
 For username/password authentication the client's authentication request
 is

     field 1: version number, 1 byte (must be 0x01)
     field 2: username length, 1 byte
     field 3: username
     field 4: password length, 1 byte
     field 5: password

 Server response for username/password authentication:

     field 1: version, 1 byte
     field 2: status code, 1 byte.
         0x00 = success
         any other value = failure, connection must be closed
 }}}

 We get "version number, 1 byte (must be 0x01)" on the request from pidgin,
 and then we use version 5 in our response. But don't we want to use
 version 1 in our response? It's not the socks version, it's the auth
 format version.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8879#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online