[tor-bugs] #8329 [Ooni]: ooni: txscapy: PcapDummyWriter has different signature method than PcapWriter

[Tor Bug Tracker & Wiki]

#8329: ooni: txscapy: PcapDummyWriter has different signature method than
PcapWriter
-----------------------+----------------------------------------------------
    Reporter:  isis    |       Owner:  isis           
        Type:  defect  |      Status:  closed         
    Priority:  normal  |   Milestone:                 
   Component:  Ooni    |     Version:                 
  Resolution:  fixed   |    Keywords:  ooni, bugreport
      Parent:          |      Points:                 
Actualpoints:          |  
-----------------------+----------------------------------------------------
Changes (by isis):

  * status:  needs_review => closed
  * resolution:  => fixed


Comment:

 Committed here:

 {{{
 ?!isis?wintermute:~/code/torproject/ooni-probe/ooni/utils ? git show
 b203c2e2
 commit b203c2e26985aa22bd8179da01fbdb642a12fc11
 Author:     Isis Lovecruft <isis at torproject.org>
 AuthorDate: Sun Feb 24 22:45:12 2013 +0000
 Commit:     Isis Lovecruft <isis at torproject.org>
 CommitDate: Mon Mar 11 19:30:00 2013 +0000

     Fix #8329, txscapy.PcapDummyWriter.write() has wrong signature method.

 diff --git a/ooni/utils/txscapy.py b/ooni/utils/txscapy.py
 index 87c0b4a..a6cacb1 100644
 --- a/ooni/utils/txscapy.py
 +++ b/ooni/utils/txscapy.py
 @@ -64,6 +64,7 @@ else:
          def __init__(self, pcap_filename, *arg, **kw):
              log.err("Initializing DummyPcapWriter. We will not actually
 write to a pcapfile")

 +        @staticmethod
          def write(self):
              pass

 }}}

 and merged into master at 875dc22d85d8391b81f6fe988f080a2cb41d65e3

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8329#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online