[tor-bugs] #8833 [Tor]: Crash on directory authority in dirserv_query_measured_bw_cache_kb

[Tor Bug Tracker & Wiki]

#8833: Crash on directory authority in dirserv_query_measured_bw_cache_kb
----------------------------+-----------------------------------------------
 Reporter:  nickm           |          Owner:                     
     Type:  defect          |         Status:  new                
 Priority:  critical        |      Milestone:  Tor: 0.2.4.x-final 
Component:  Tor             |        Version:  Tor: 0.2.4.12-alpha
 Keywords:  tor-auth crash  |         Parent:                     
   Points:                  |   Actualpoints:                     
----------------------------+-----------------------------------------------

Comment(by nickm):

 Looks like router_counts_toward_thresholds is calling
 dirserv_query_measured_bw_cache_kb with a bogus identity, probably because
 the node's ri field isn't set.

 Possibly we didn't find this in testing because our compilers correctly
 determined that we can postpone the computation until later when we know
 we'll need its result.

 Fixing now...

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8833#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online