[tor-bugs] #8606 [Stem]: Controller's extend_circuit() fails to remove temporary listeners

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Mar 29 16:57:41 UTC 2013


#8606: Controller's extend_circuit() fails to remove temporary listeners
--------------------+-------------------------------------------------------
 Reporter:  atagar  |          Owner:  atagar
     Type:  defect  |         Status:  new   
 Priority:  minor   |      Milestone:        
Component:  Stem    |        Version:        
 Keywords:          |         Parent:        
   Points:          |   Actualpoints:        
--------------------+-------------------------------------------------------
 When the extend_circuit() method is called with await_build as True it
 attaches a temporary event listener (add_event_listener()). It looks like
 we never detach this, so repeated calls will accumulate listeners. This
 won't result in errors, but it will impact performance if we accumulate a
 lot of them.

 We should either...

 a. detach the listener when we're done with it, even in error conditions

 b. reuse the listener if one has already been attached

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8606>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list