[tor-bugs] #6572 [Tor]: “Bug: Circuit somehow completed a hop while the network was not live.”

[Tor Bug Tracker & Wiki]

#6572: “Bug: Circuit somehow completed a hop while the network was not live.”
---------------------------------------+------------------------------------
 Reporter:  bpmcontrol                 |          Owner:  mikeperry         
     Type:  defect                     |         Status:  assigned          
 Priority:  normal                     |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                        |        Version:                    
 Keywords:  tor-client 024-deferrable  |         Parent:                    
   Points:                             |   Actualpoints:                    
---------------------------------------+------------------------------------
Changes (by nickm):

  * status:  needs_information => assigned


Comment:

 One stupid possibility: Our time mostly isn't guaranteed to be monotonic.
 I mean, probably it is? And bpmcontrol said that there weren't any
 warnings about jumpy or backwards time.  But still.

 > My question is: Where should we call
 circuit_build_times_network_is_live() so that we're *sure* that we
 received fresh, valid data from the Internet?

 Oh wow; I think Roger knows this stuff better than I.  If anybody knows it
 at all.

 I think that the call in connection_or_process_cells_from_inbuf *should*
 be good enough. If we got cells, we're reading data.  Certainly we can't
 have a circuit become OPEN without receiving a CREATED or EXTENDED cell,
 right?

 Oh hey.  This message happens if the circuit was _launched_ when we were
 down, not if it was _completed_ when we were down, right? That's totally
 valid.  Launching a circuit when the network is down IIUC means that we
 thought the network wasn't working, but we decided to poke it with a
 circuit anyway in case it really is up again.  We'll decide that the
 network is up only when we finally get a successful OR connection IIUC.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6572#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online