[tor-bugs] #7482 [Tor]: Discard nonsense in address.c about v4-mapped addresses

[Tor Bug Tracker & Wiki]

#7482: Discard nonsense in address.c about v4-mapped addresses
-----------------------------+----------------------------------------------
 Reporter:  nickm            |          Owner:                    
     Type:  defect           |         Status:  needs_revision    
 Priority:  normal           |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor              |        Version:                    
 Keywords:  tor-client ipv6  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------
Changes (by sysrqb):

  * status:  needs_review => needs_revision


Comment:

 I guess we were both looking at this at the same time. This patch looks
 reasonable for this bug. The only improvements I have are to mention that
 ::ffff:1.2.3.4 is treated as internal in the block comment for
 tor_addr_is_internal_ and to add another clarifying comment at ~340 when
 you check this case, similar to the case above and below it when you check
 the RFC compliant addresses.

 As for the internal vs private, in this case they're being lumped
 together, so I think you can change private_nets to internal_nets or
 local_nets or similar.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7482#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online