[tor-bugs] #8206 [Tor]: Check return values from fcntl and setsockopt

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Mar 18 19:42:46 UTC 2013


#8206: Check return values from fcntl and setsockopt
-----------------------+----------------------------------------------------
    Reporter:  nickm   |       Owner:                    
        Type:  defect  |      Status:  closed            
    Priority:  minor   |   Milestone:  Tor: 0.2.4.x-final
   Component:  Tor     |     Version:                    
  Resolution:  fixed   |    Keywords:  tor-relay easy    
      Parent:          |      Points:                    
Actualpoints:          |  
-----------------------+----------------------------------------------------

Comment(by flupzor):

 I'm sorry for my terrible diff. And it seems that i've actually forgotten
 some more fcntl's

 in src/common/util.c in the windows part:
 3967   /* Set stdout/stderr pipes to be non-blocking */
 3968   fcntl(process_handle->stdout_pipe, F_SETFL, O_NONBLOCK);
 3969   fcntl(process_handle->stderr_pipe, F_SETFL, O_NONBLOCK);

 And attached is a diff i wrote earlier for something in
 src/common/compat.c i forgot as well.

 I tried writing a diff for the stuff above but i can't concentrate at all
 at the moment.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8206#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list