[tor-bugs] #8298 [Tor]: Do not start write to connection if blocked on bw

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Mar 15 17:38:00 UTC 2013


#8298: Do not start write to connection if blocked on bw
------------------------------+---------------------------------------------
 Reporter:  cypherpunks       |          Owner:                    
     Type:  defect            |         Status:  needs_review      
 Priority:  minor             |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor               |        Version:                    
 Keywords:  kludgy tor-relay  |         Parent:                    
   Points:                    |   Actualpoints:                    
------------------------------+---------------------------------------------

Comment(by nickm):

 This fix looks obviously correct to me.

 I suspect the current behavior is ''should'' be harmless, since as soon as
 the write event arrives, connection_bucket_write_limit() ''should'' return
 0.  But still it's a pointless trip through the kernel.

 I made a branch in bug8298; please test and review?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8298#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list