[tor-bugs] #8203 [Tor]: Inconsistent stream events when resolving hostname

[Tor Bug Tracker & Wiki]

#8203: Inconsistent stream events when resolving hostname
------------------------------------------------------+---------------------
 Reporter:  Desoxy                                    |          Owner:                    
     Type:  defect                                    |         Status:  needs_revision    
 Priority:  normal                                    |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                                       |        Version:                    
 Keywords:  tor-client controller dns 024-deferrable  |         Parent:                    
   Points:                                            |   Actualpoints:                    
------------------------------------------------------+---------------------
Changes (by nickm):

  * keywords:  tor-client => tor-client controller dns 024-deferrable
  * status:  needs_review => needs_revision


Comment:

 I think that the change in connection_edge, where you make conn->address
 no longer get set to tor_internal, seems likely to be iffy.  Perhaps it
 would be better to change it to
 {{{
    if (!ap_conn->_base.address) {
       ap_conn->_base.address = tor_strdup("(Tor_internal)");
    }
 }}}
 or something.  If it's interfering with the SENT_RESOLVE event, we could
 move the SENT_RESOLVE event earlier in the function.


 As for the other stuff, I like the idea of making this consistent!
 Certainly, the change is compatible with the text and spirit of the design
 and specification.  Have you tested the changes with Vidalia?  I'd like to
 get these changes tested with Vidalia and other controllers if possible to
 make sure that they're not going to break any of the controllers'
 assumptions.

 (Marking as "0.2.4" deferrable, since even though I like this, it wouldn't
 be a disaster if it went in 0.2.5.1-alpha instead.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8203#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online