[tor-bugs] #8440 [Ooni]: ooni: tls_handshake.py host and port options do not work

[Tor Bug Tracker & Wiki]

#8440: ooni: tls_handshake.py host and port options do not work
---------------------------------+------------------------------------------
 Reporter:  isis                 |          Owner:  isis
     Type:  defect               |         Status:  new 
 Priority:  normal               |      Milestone:      
Component:  Ooni                 |        Version:      
 Keywords:  ooni, tls_handshake  |         Parent:      
   Points:                       |   Actualpoints:      
---------------------------------+------------------------------------------
 [https://github.com/TheTorProject/ooni-probe/pull/58#issuecomment-14286021
 hellais commented] on my pull request that

 {{{
 When running this with:

 $ ./bin/ooniprobe nettests/experimental/tls_handshake.py -h 38.229.72.14
 -p 443

 I get

 Log opened.
 [D] No test deck detected
 [D] processing options
 [D] Running [(<class
 'nettests.experimental.tls_handshake.TLSHandshakeTest'>,
 'test_tlsv1_handshake')]
 [D] Options {'inputs': [None], 'version': '0.0.2', 'name': 'tls-
 handshake'}
 [D] cmd_line_options {'pcapfile': None, 'help': 0, 'subargs': ('-h',
 '38.229.72.14', '-p', '443'), 'resume': 0, 'parallelism': '10', 'test':
 'nettests/experimental/tls_handshake.py', 'logfile': None, 'collector':
 None, 'reportfile': None}
 Traceback (most recent call last):
   File "/Users/x/code/OONI/ooni-probe/ooni/reporter.py", line 275, in
 __init__
     socksport=int(config.tor.socks_port))
 TypeError: int() argument must be a string or a number, not 'NoneType'
 [D] Creating report_tls_handshake_2013-03-01T120015Z.yamloo
 [D] Writing report with YAML reporter
 Reporting to file report_tls_handshake_2013-03-01T120015Z.yamloo
 [D] Not going to resume tls_handshake.py
 [D] input_unit_items: 1
 [D] test_case_number: 1.0
 [D] Test case number: 1.0
 [D] Total iterations: 1.0
 [D] Current iteration: 0.0
 [D] Running tls_handshake.py with input unit <<class
 'ooni.inputunit.InputUnit'> inputs=<listiterator object at 0x10f2536d0>>
 [D] Running test cases with input unit
 [D] Running test with this input None
 [D] Processing test_tlsv1_handshake
 [D] Running test_tlsv1_handshake with None...
 [!] No SSL/TLS context chosen! Defaulting to TLSv1...
 [D] [tls_handshake.py] 0.0%
 Unhandled error in Deferred:
 Unhandled Error
 Traceback (most recent call last):
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 464, in _startRunCallbacks
     self._runCallbacks()
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 551, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 397, in errback
     self._startRunCallbacks(fail)
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 464, in _startRunCallbacks
     self._runCallbacks()
 --- <exception caught here> ---
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 551, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/Users/x/code/OONI/ooni-
 probe/nettests/experimental/tls_handshake.py", line 693, in
 handshakeFailed
     addr, port = host
 exceptions.TypeError: 'NoneType' object is not iterable

 Traceback (most recent call last):
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/base.py", line 1178, in mainLoop
     self.runUntilCurrent()
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/base.py", line 773, in runUntilCurrent
     f(*a, **kw)
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 397, in errback
     self._startRunCallbacks(fail)
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 464, in _startRunCallbacks
     self._runCallbacks()
 --- <exception caught here> ---
   File "/Users/x/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 551, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/Users/x/code/OONI/ooni-
 probe/nettests/experimental/tls_handshake.py", line 405, in
 connectionShutdown
     peername, peerport = host
 exceptions.TypeError: 'NoneType' object is not iterable`
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8440>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online