[tor-bugs] #8273 [Tor]: Set flag thresholds and flags based on measured bandwidth

[Tor Bug Tracker & Wiki]

#8273: Set flag thresholds and flags based on measured bandwidth
----------------------+-----------------------------------------------------
 Reporter:  nickm     |          Owner:                    
     Type:  defect    |         Status:  needs_revision    
 Priority:  critical  |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor       |        Version:                    
 Keywords:  tor-auth  |         Parent:                    
   Points:            |   Actualpoints:                    
----------------------+-----------------------------------------------------

Comment(by andrea):

 Replying to [comment:15 nickm]:
 > Replying to [comment:14 andrea]:
 > > Replying to [comment:2 nickm]:
 > > > Quick notes:
 > > >   * The "/* Check if we cleared the whole thing and free if so */"
 seems unnecessary.  dirserv_clear_measured_bw_cache will free this
 eventually, right?
 > >
 > > It saves one extra block of memory for the map itself when it's empty.
 >
 > Okay. I don't think this will make a big difference, but it can't hurt
 to leave it in.
 >
 >  [...]
 > > > And a trickier issue:
 > > >   * When we have a sufficient number/fraction of nodes with measured
 bandwidth, I think we should stop believing nodes' advertised bandwidths.
 That is, if the number/fraction of measured nodes is high enough, then we
 should *never* call unmeasured nodes Fast, or Guard, or HSDir, or anything
 else that depends on bandwidth.  (Plausible?)
 > >
 > > That sounds like a good idea potentially; what about other
 circumstances we use the advertised bandwidth?  Should we consider those
 cases or just concern ourselves with the flags?
 >
 > I think we should, for this ticket, just look at the flags.  Other users
 of advertised bandwidth can get other tickets if they don't have them
 already.  (Shall we open those tickets as we work on this one?)
 >
 > I'll review the changes you mentioned above Friday (I hope); are you
 okay with implementing the "trickier issue" thing here?  Let's talk online
 and open the new tickets together, unless you're feeling psyched to do
 them yourself.

 I just created 8435; want me to go ahead and implement it?  It seems like
 something we should do, but also like more of a feature than a bugfix, and
 the deadline for those is past.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8273#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online