[tor-bugs] #8367 [Tor]: Regression in git master: Can't bootstrap with bridges

[Tor Bug Tracker & Wiki]

#8367: Regression in git master: Can't bootstrap with bridges
--------------------------------+-------------------------------------------
 Reporter:  nickm               |          Owner:                    
     Type:  defect              |         Status:  needs_review      
 Priority:  critical            |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                 |        Version:                    
 Keywords:  tor-client bridges  |         Parent:                    
   Points:                      |   Actualpoints:                    
--------------------------------+-------------------------------------------

Comment(by andrea):

 Okay, the problem was that in add_an_entry_guard(), nickm's patch only set
 is_dir_cache on the case that the guard was already in the list and
 entry_guard_get_by_id_digest() returns non-NULL, but not in the similar
 code sequence in a few lines below when it isn't found and the chosen node
 gets added.  I surmise that dcf's test of nickm's branch worked because he
 already had some cached consensus data, and it called
 entry_guard_set_status() via entry_guards_compute_status() and
 directory_info_has_arrived(), which is not possible on a clean bootstrap
 if this bug prevents ever making contact with a directory server.

 Anyway, the fix is easy: modify the other case in add_an_entry_guard() as
 in nickm's version.  See the bug8367 branch in my repository, which works
 starting ex nihilo for me.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8367#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online