[tor-bugs] #9022 [Pluggable transport]: Create an XMPP pluggable transport

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jun 27 12:55:27 UTC 2013


#9022: Create an XMPP pluggable transport
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  feynman 
     Type:  task                 |         Status:  accepted
 Priority:  normal               |      Milestone:          
Component:  Pluggable transport  |        Version:          
 Keywords:                       |         Parent:          
   Points:                       |   Actualpoints:          
---------------------------------+------------------------------------------

Comment(by asn):

 Replying to [comment:58 feynman]:
 > I have the whitelist feature in place and documented in the readme file
 in the git repository (https://github.com/aeftimia/hexchat).
 >
 > I *think* I have worked out all the bugs. Is there anything else I
 should do? I guess I need to comment the code, but other than that, is
 there anything else that needs to be done before this can become a
 pluggable transport?

 Hey there,

 whitelist code looks good.

 BTW, in your code, it seems like you are using 'return' as a function. In
 reality, it's simply a statement. This means that 'return()' doesn't
 return nothing, but instead it returns an empty tuple.
 I would suggest transforming 'return(x)' to 'return x'.

 Also, would you be interested in turning your CLI parsing code to use
 argparse? Manually parsing 'sys.argv' is extremely ghetto, not well
 readable and it doesn't scale well. Cool kids use argparse these days:
 http://docs.python.org/dev/library/argparse.html

 I tested the code a bit and it seems to work (used same JIDs for
 client/server though). I should test with different JID, then we should do
 some code cleanups and start thinking of deploying this transport. This
 means that we should setup a stable/fast bridge, and prepare some testing
 bundles.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9022#comment:59>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list