[tor-bugs] #9122 [Tor]: Recent regression causing confparse error

[Tor Bug Tracker & Wiki]

#9122: Recent regression causing confparse error
-------------------------------------+--------------------------------------
 Reporter:  atagar                   |          Owner:                    
     Type:  defect                   |         Status:  needs_review      
 Priority:  major                    |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                      |        Version:                    
 Keywords:  tor-client 023-backport  |         Parent:                    
   Points:                           |   Actualpoints:                    
-------------------------------------+--------------------------------------
Changes (by nickm):

  * status:  new => needs_review
  * keywords:  => tor-client 023-backport
  * milestone:  => Tor: 0.2.4.x-final


Comment:

 Looks like you don't actually need to set ContactInfo.  Passing an empty
 configuration to LOADCONF will do fine too.

 It comes down to the the call in hanle_control_loadconf:
 {{{
   retval = options_init_from_string(NULL, body, CMD_RUN_TOR, NULL,
 &errstring);
 }}}

 That initial NULL means "don't use any defaults", which is incorrect on so
 many levels.  The underlying bug exists back to 0.2.3, and is probably
 causing some weird behavior for somebody somewhere.

 "bug9122" has an apparent fix against 0.2.4.  "bug9122_023" is a backport
 of that commit to 0.2.3.  Please review?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9122#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online