[tor-bugs] #7953 [Tor]: Control port method to get v3 directory informaion

[Tor Bug Tracker & Wiki]

#7953: Control port method to get v3 directory informaion
--------------------------------------------------+-------------------------
 Reporter:  atagar                                |          Owner:                    
     Type:  enhancement                           |         Status:  new               
 Priority:  major                                 |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                                   |        Version:                    
 Keywords:  tor-client controller needs-proposal  |         Parent:                    
   Points:                                        |   Actualpoints:                    
--------------------------------------------------+-------------------------

Comment(by atagar):

 Hi Nick. Thanks for the pointer!

 * NS_CONTROL_PORT didn't exist back in the dark ages of directory v2
 (3ad6dc0e). Nowadays it's used in routerstatus_format_entry() of
 dirserv.c.

 * In 3ad6dc0e routerstatus_format_entry() did not support multiple
 formats. It always wrote 'r', 's', and 'v' lines. Those are what a v2
 router status entry consists of.

 * In master for the NS_CONTROL_PORT format it outputs 'r', 'a', 's', 'v',
 'w', and 'p'. This matches with the definition of a v3 router status entry
 minus 'm' entries (which only appear in votes).

 * These attributes have been added over time as the v3 format evolved. My
 guess is that no one knew that 'NS_CONTROL_PORT' was meant to be the v2
 format. If we wanted that to be the case then we probably should have
 included the version in the enumeration (like NS_V2).

 Cheers! -Damian

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7953#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online