[tor-bugs] #9090 [Tor]: Problems in bug9002 fix (was: Memory leak in bug9002 fix)

[Tor Bug Tracker & Wiki]

#9090: Problems in bug9002 fix
--------------------------------------------+-------------------------------
 Reporter:  nickm                           |          Owner:                    
     Type:  defect                          |         Status:  new               
 Priority:  normal                          |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                             |        Version:                    
 Keywords:  tor-client tor-hs 023-backport  |         Parent:                    
   Points:                                  |   Actualpoints:                    
--------------------------------------------+-------------------------------

Old description:

> Before we return -2 in our fix for #9002, we should make sure we free the
> parsed hidden service descriptor with
> "rend_service_descriptor_free(parsed);"

New description:

 Before we return -2 in our fix for #9002, we should make sure we free the
 parsed hidden service descriptor with
 "rend_service_descriptor_free(parsed);"

 Also, we should actually treat it as an error in the
 rend_cache_store_v2_desc_as_client() case. :/

--

Comment(by nickm):

 A

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9090#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online