[tor-bugs] #9043 [Tor]: Replace `pkey_eq` with `EVP_PKEY_cmp`

[Tor Bug Tracker & Wiki]

#9043: Replace `pkey_eq` with `EVP_PKEY_cmp`
-----------------------------+----------------------------------------------
 Reporter:  marek            |          Owner:                    
     Type:  enhancement      |         Status:  needs_review      
 Priority:  trivial          |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor              |        Version:                    
 Keywords:  easy tor-client  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------
Changes (by marek):

  * status:  new => needs_review


Comment:

 Attached patch replaces the `pkey_cmp` function with a call to
 `EVP_PKEY_cmp(cert_key, link_key) == 1`. I am not an openssl / crypt
 expert, so please, please can someone competent comment that both methods
 are semantically the same?

 Additionally the patch removes recently introduced `test_tortls.c` as we
 don't really need to check if openssl works.

 I tried to compile this with openssl 0.9.7 and failed, tried to compile
 this with 0.9.8 and succeeded (ie: as expected).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9043#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online