[tor-bugs] #7721 [Flashproxy]: flashproxy browser add-on

[Tor Bug Tracker & Wiki]

#7721: flashproxy browser add-on
------------------------+---------------------------------------------------
 Reporter:  proper      |          Owner:  dcf         
     Type:  task        |         Status:  needs_review
 Priority:  minor       |      Milestone:              
Component:  Flashproxy  |        Version:              
 Keywords:              |         Parent:              
   Points:              |   Actualpoints:              
------------------------+---------------------------------------------------

Comment(by dcf):

 Replying to [comment:7 cypherpunks]:
 > I made one for Firefox:
 > https://addons.mozilla.org/de/firefox/addon/tor-flashproxy-badge/

 Thank you for making this. It is good to have something available for
 Firefox. However, I have found two problems.

 First, it crashes and doesn't actually serve any clients.
 {{{
 error: tor-flashproxy-badge: An exception occurred.
 ReferenceError: clearTimeout is not defined
 resource://jid0-1kqapo5buhwjbqft5beuxhxzjca-at-jetpack/tor-flashproxy-
 badge/lib/flashproxy.js 285
 Traceback (most recent call last):
   File "resource://gre/modules/commonjs/sdk/timers.js", line 31, in notify
     callback.apply(null, args);
   File "resource://jid0-1kqapo5buhwjbqft5beuxhxzjca-at-jetpack/tor-
 flashproxy-badge/lib/flashproxy.js", line 285, in
     clearTimeout(this.flush_timeout_id);
 }}}
 This is a problem; my hourly client tests have been failing more often
 than not for weeks now, and I've been checking and re-checking the flash
 proxy code to try and find the problem. I now think it is caused by this
 add-on claiming to serve clients and then crashing. I'm afraid I'm going
 to try and block access by this add-on until the problem is fixed.

 Second, the code is a modified fork of `flashproxy.js`.
 https://github.com/reezer/tor-flashproxy-
 badge/blob/master/lib/flashproxy.js
 There are gratuitous changes like [https://github.com/reezer/tor-
 flashproxy-
 badge/commit/ad01d42763960a28f05b22537ba325a7fdcb1feb#lib/flashproxy.js
 changing the indentation level]; this will only make it harder to merge
 updates and bug fixes. How do you plan to keep the code up to date? At
 this point, I prefer the model used by Cupcake, where it acts as a wrapper
 around the same proxy code served to everyone else.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7721#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online