[tor-bugs] #9017 [Tor]: Crash in assert_connection_ok

[Tor Bug Tracker & Wiki]

#9017: Crash in assert_connection_ok
--------------------------+-------------------------------------------------
 Reporter:  usuality      |          Owner:                    
     Type:  defect        |         Status:  needs_revision    
 Priority:  major         |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor           |        Version:  Tor: 0.2.3.25     
 Keywords:  023-backport  |         Parent:                    
   Points:                |   Actualpoints:                    
--------------------------+-------------------------------------------------

Comment(by andrea):

 Hmm; the non-immediate-return case code for handling when the connection
 completes is in connection_edge_finished_connecting(); the code is
 substantially similar to the latter part of connection_exit_connect() and
 this should be refactored to avoid the duplication, but probably not in
 maint-0.2.3.  The only differences I see are

  * connection_edge_finished_connecting() calls
 rep_hist_note_exit_stream_opened(conn->port) before it puts the connection
 in EXIT_CONN_STATE_OPEN.

  * connection_edge_finished_connecting() has an extra
 connection_edge_process_inbuf(edge_conn, 1) before it returns, which
 connection_exit_connect() lacks.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9017#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online