[tor-bugs] #8437 [EFF-HTTPS Everywhere]: Prevent invalid rules from being committed, or at leat warn when they are

[Tor Bug Tracker & Wiki]

#8437: Prevent invalid rules from being committed, or at leat warn when they are
----------------------------------+-----------------------------------------
 Reporter:  schoen                |          Owner:  yan         
     Type:  task                  |         Status:  needs_review
 Priority:  normal                |      Milestone:              
Component:  EFF-HTTPS Everywhere  |        Version:              
 Keywords:                        |         Parent:              
   Points:                        |   Actualpoints:              
----------------------------------+-----------------------------------------
Changes (by zyan):

  * status:  assigned => needs_review


Comment:

 After some reading, it seemed that the way to do this is to have a server-
 side update hook that runs the build script (which includes ruleset
 validation) in a temporary directory that includes the changes being
 pushed and rejects the push if the build fails. An update hook is similar
 to a pre-receive hook from what I understand, except it runs once per
 branch.

 With much help from http://stackoverflow.com/questions/4541417/how-can-i
 -make-it-so-git-rejects-pushing-code-that-wont-compile, I've made a draft
 of this script here: https://github.com/diracdeltas/https-
 everywhere/blob/a63659551e5ba5f39e4935039ae2d3b7e2f2325d/hooks/update

 It should go in .git/hooks.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8437#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online