[tor-bugs] #9199 [BridgeDB]: Rethink the logging of BridgeDB

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jul 17 05:07:18 UTC 2013

#9199: Rethink the logging of BridgeDB
 Reporter:  asn       |          Owner:  isis        
     Type:  task      |         Status:  needs_review
 Priority:  normal    |      Milestone:              
Component:  BridgeDB  |        Version:              
 Keywords:            |         Parent:              
   Points:            |   Actualpoints:              
Changes (by isis):

  * status:  needs_revision => needs_review


 Replying to [comment:13 asn]:
 > hey isis,

 Hi asn, thanks for the review!

 > your branch contains non-logging-related changes. Can you put these in a
 different branch and trac ticket, so that we only talk about logging-
 related changes here. Examples:
 > 03e79f9, 9aaf152, 96a01f2, 7db2fc8, 540dcf2ec02, a811d3a

 > Replying to isis:
 > >    Ah, forgot. This also rewrites the Conf() configuration class (the
 old one was an old-style class, and would have had serialization
 problems), and with that #6127 is fixed too.

 > Can you put this in another branch and trac ticket?

 The config and extra fixes are now #9277, which is in this branch:

 Replying to [comment:15 asn]:
 > Also, can you name your module logging so that you don't need to do the
 rewriting in 07dc793..44544c8?

 Done. :)

 Here: https://github.com/isislovecruft/bridgedb/compare/feature;9199

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9199#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list