[tor-bugs] #8949 [Tor]: Add a way to do mocking for Tor unit tests

[Tor Bug Tracker & Wiki]

#8949: Add a way to do mocking for Tor unit tests
--------------------------------+-------------------------------------------
 Reporter:  nickm               |          Owner:                    
     Type:  enhancement         |         Status:  needs_review      
 Priority:  major               |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                 |        Version:                    
 Keywords:  tor-client testing  |         Parent:                    
   Points:                      |   Actualpoints:                    
--------------------------------+-------------------------------------------

Comment(by andrea):

 Begin code review:

 f7d654b81e1a65803c22bb53fc1d3a2021d87d50:
  * By modifying src_or_libtor_testing_a_CPPFLAGS, I presume the intent is
 to build everything twice, once for the tor binary and once for the unit
 tests.
  * I am deficient in automake clue here; are we certain this builds a
 complete separate set of object files, rather than just seeing one built
 and then not trying to rebuild it?
  * Building everything twice seems icky, but I agree the other options
 seem even ickier.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8949#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online