[tor-bugs] #7920 [Firefox Patch Issues]: TBB does not follow the current Windows theme

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jan 25 19:40:37 UTC 2013


#7920: TBB does not follow the current Windows theme
----------------------------------+-----------------------------------------
 Reporter:  runa                  |          Owner:  mikeperry
     Type:  defect                |         Status:  new      
 Priority:  normal                |      Milestone:           
Component:  Firefox Patch Issues  |        Version:           
 Keywords:                        |         Parent:           
   Points:                        |   Actualpoints:           
----------------------------------+-----------------------------------------

Comment(by mcs):

 OK, this is kind of messy.  Through use of the debugger and reading the
 Firefox code, we discovered that in certain cases the substitute colors
 that we introduced to fix #6786 are not used.  Instead, OS calls are used
 to draw the background for widgets (e.g., for an HTML input field).  This
 happens with the classic themes on Windows and when the Windows
 accessibility control panel is used to enable "High Contrast Black."
 These colors are hidden from web apps (CSS computed styles continue to
 return our substitute colors).

 The problem is, in some cases a system/native background is used (e.g.,
 black) with a substitute foreground color (i.e., black).  Hence, black on
 black.  Our approach to fixing this is to use the system/native foreground
 color in this situation.  We will post a patch soon.

 Note that on Mac OS, "White on black" display is done in a different way
 that avoids this problem (I think the OS inverts colors during rendering).
 I am not sure about Linux, but our fix will apply for all platforms.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7920#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list