[tor-bugs] #7924 [Compass]: Compass: search by AS does not work

[Tor Bug Tracker & Wiki]

#7924: Compass: search by AS does not work
---------------------+------------------------------------------------------
 Reporter:  mo       |          Owner:  cwacek      
     Type:  defect   |         Status:  needs_review
 Priority:  normal   |      Milestone:              
Component:  Compass  |        Version:              
 Keywords:           |         Parent:              
   Points:           |   Actualpoints:              
---------------------+------------------------------------------------------
Changes (by cwacek):

  * status:  needs_revision => needs_review


Comment:

 Replying to [comment:8 karsten]:
 > I just set up a new VM on EC2 running Compass master (8c2259c), but the
 issue is still there.  Hmmmmmm...

 Okay, that was ridiculous, but I think I've actually fixed it this time.

 In versions below 2.7.3, shlex doesn't properly account for
 unicode characters. This only occurred with Apache for some reason,
 either because mod_wsgi uses Python_2.7.2+ or because Apache was
 handing it Unicode strings.

 This fix simply converts the string to ASCII before handing it to
 shlex. Since the set of valid characters for an AS parameter are
 'AS1234567890[],' and should always encode to ASCII, this should be
 safe.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7924#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online