[tor-bugs] #3927 [Vidalia]: Vidalia torrc editor 'Save settings' checkbox is useless

[Tor Bug Tracker & Wiki]

#3927: Vidalia torrc editor 'Save settings' checkbox is useless
---------------------+------------------------------------------------------
 Reporter:  rransom  |          Owner:  chiiph         
     Type:  defect   |         Status:  new            
 Priority:  minor    |      Milestone:                 
Component:  Vidalia  |        Version:  Vidalia: 0.2.20
 Keywords:  easy     |         Parent:                 
   Points:           |   Actualpoints:                 
---------------------+------------------------------------------------------
Changes (by onizuka):

 * cc: onizuka.xxxx@… (added)
  * version:  => Vidalia: 0.2.20


Comment:

 I agree with rransom.

 A glance at the master branch's code (0.2.21) revealed that the
 application has not been designed to deal with a 'temporary setting' :
 SAVECONF is called in ServiceSettings.cpp, ConfigDialog.cpp and
 TorrcDialog.cpp. ConfigDialog should be the only one to handle the
 SAVECONF command otherwise the service editing & the torrc editing
 override each other - because it iterates through a stack to save the
 whole set of pages -, thus the undesired behaviours which occur when a
 SAVECONF is issued after a SETCONF.

 Since the feature is not really essential and seems to have disappeared
 from branch alpha (0.3.3-alpha) I also suggest to remove the checkbox from
 the TorrcDialog.ui in the current branch master.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3927#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online