[tor-bugs] #7932 [Tor]: Clarify that pre-method 9 footers contains signatures (was: Stem complains that key certificate in old vote doesn't end with a 'dir-key-certification' line)

[Tor Bug Tracker & Wiki]

#7932: Clarify that pre-method 9 footers contains signatures
---------------------+------------------------------------------------------
 Reporter:  karsten  |          Owner:  atagar
     Type:  defect   |         Status:  new   
 Priority:  trivial  |      Milestone:        
Component:  Tor      |        Version:        
 Keywords:           |         Parent:        
   Points:           |   Actualpoints:        
---------------------+------------------------------------------------------
Changes (by atagar):

  * priority:  normal => trivial
  * component:  Stem => Tor


Comment:

 Ahh, I missed that. Thanks!

 Pushed a fix...

 https://gitweb.torproject.org/stem.git/commitdiff/98a8842c9ab800f9891a01caf35d02f2dfc60809

 > But: note that Stem parses the 17:00:00 vote without issues, but has
 trouble parsing the 18:00:00 vote. I don't see what difference between the
 two votes would cause that. Any ideas? Can you try out parsing these two
 votes with Stem and take a look yourself?

 I did and they both appeared to break the parser. Maybe I misread the
 output yesterday...

 > That being said, it might make sense to tweak those parts of dir-
 spec.txt to make them less confusing.

 A small clarification would be nice. Maybe something like...

 {{{
 diff --git a/dir-spec.txt b/dir-spec.txt
 index ca5434b..eb1b55b 100644
 --- a/dir-spec.txt
 +++ b/dir-spec.txt
 @@ -1489,6 +1489,9 @@
     It contains two subsections, a bandwidths-weights line and a
     directory-signature.

 +   Prior to conensus method 9 footers only contained directory-signatures
 +   without a 'directory-footer' line.
 +
     The bandwidths-weights line appears At Most Once for a consensus. It
 does
     not appear in votes.
 }}}

 Sending this over to Nick to see what he thinks.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7932#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online