[tor-bugs] #7631 [Stem]: Try a PEP8 style checker

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jan 4 16:27:26 UTC 2013


#7631: Try a PEP8 style checker
----------------------------+-----------------------------------------------
    Reporter:  atagar       |       Owner:  atagar  
        Type:  enhancement  |      Status:  reopened
    Priority:  minor        |   Milestone:          
   Component:  Stem         |     Version:          
  Resolution:               |    Keywords:  testing 
      Parent:               |      Points:          
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by atagar):

  * status:  closed => reopened
  * resolution:  wontfix =>


Comment:

 Reopening. This is understandably a pain point for new contributors so we
 really should change it. I'd be fine with replacing our style checker [1]
 with something that gets us closer to PEP8 compliance. After all, it's
 easier for me to change my habits and vimrc than ask it of the world. ;)

 My one caveat to PEP8 is the four space indentations. From what I've seen
 python projects very widely on this. If active contributors really want us
 to move to four spaces then fine, but I'd like to have some discussion
 around that first.

 I'm neck deep in the arm migration at present so it'll be a while before I
 can get to this. If stem's style really annoys you then you're more than
 welcome to take the lead on this!

 [1]
 https://gitweb.torproject.org/stem.git/blob/HEAD:/test/check_whitespace.py

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7631#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list