[tor-bugs] #8353 [Ooni]: ooni: Add support for manual TLS/SSL handshakes to tls_handshake.py

[Tor Bug Tracker & Wiki]

#8353: ooni: Add support for manual TLS/SSL handshakes to tls_handshake.py
-------------------------+--------------------------------------------------
 Reporter:  isis         |          Owner:  isis        
     Type:  enhancement  |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Ooni         |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------

Comment(by aagbsn):

 A few minor things:

 in the report:
 cert_public_key is of type OpenSSL.crypto.PKey object
 cert_subject is of type X509Name object
 server_cert has extra newlines. I'm not sure why this is though.

 would be nice:
 add the ciphersuite that was selected to the report (in addition to
 server_ciphersuite)


 input arguments:
 it would be nice if hostnames would work in addition to ip addresses.
 tls_handshake -3 -h ipaddress -p 443 fails with error:
 {{{
 Traceback (most recent call last):
   File "/home/user/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 294, in addCallbacks
     self._runCallbacks()
   File "/home/user/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 576, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/home/user/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 422, in errback
     self._startRunCallbacks(fail)
   File "/home/user/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 489, in _startRunCallbacks
     self._runCallbacks()
 --- <exception caught here> ---
   File "/home/user/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 576, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/home/user/code/ooni-
 probe/nettests/experimental/tls_handshake.py", line 584, in
 handshakeFailed
     addr, port = host
 exceptions.TypeError: 'NoneType' object is not iterable
 }}}

 tls_handshake -2 -f ssl_host (a.google.ip:443) fails with error:

 {{{
 [!] [Failure instance: Traceback: <class 'OpenSSL.SSL.Error'>: [('SSL
 routines', 'SSL_CTX_set_cipher_list', 'no cipher match')]
 /home/user/code/ooni-probe/ooni/runner.py:233:runTestCasesWithInput
 /home/user/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py:138:maybeDeferred
 /home/user/code/ooni-
 probe/nettests/experimental/tls_handshake.py:602:test_tlsv1_handshake
 /home/user/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py:1214:unwindGenerator
 --- <exception caught here> ---
 /home/user/.virtualenvs/ooni/lib/python2.7/site-
 packages/twisted/internet/defer.py:1071:_inlineCallbacks
 /home/user/code/ooni-
 probe/nettests/experimental/tls_handshake.py:594:deferMakeConnection
 /home/user/code/ooni-
 probe/nettests/experimental/tls_handshake.py:218:makeConnection
 /home/user/code/ooni-
 probe/nettests/experimental/tls_handshake.py:186:getContext
 ]
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8353#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online