[tor-bugs] #8298 [Tor]: Do not start write to connection if blocked on bw

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Feb 21 15:09:40 UTC 2013


#8298: Do not start write to connection if blocked on bw
-------------------------+--------------------------------------------------
 Reporter:  cypherpunks  |          Owner:                    
     Type:  defect       |         Status:  new               
 Priority:  minor        |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor          |        Version:                    
 Keywords:  kludgy       |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------
 Tor can to start write to connection just because something wrote to
 conn's outbuf by _connection_write_to_buf_impl(). While connection can be
 blocked on bw still.
 If buckets empty it can't to write anything anyway (need investigation for
 sure).

 Suggested idea to fix, could be looks like:
 {{{
   if (conn->write_event && !conn->write_blocked_on_bw) {
     connection_start_writing(conn);
   }
 }}}

 Kludgy probably. #8111 will fix it generally for 0.2.5 I hopes.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8298>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list