[tor-bugs] #8234 [Tor bundles/installation]: mac os x ff17 crashes

[Tor Bug Tracker & Wiki]

#8234: mac os x ff17 crashes
--------------------------------------+-------------------------------------
 Reporter:  ioerror                   |          Owner:  ioerror     
     Type:  task                      |         Status:  needs_review
 Priority:  blocker                   |      Milestone:              
Component:  Tor bundles/installation  |        Version:              
 Keywords:                            |         Parent:              
   Points:                            |   Actualpoints:              
--------------------------------------+-------------------------------------
Changes (by mikeperry):

  * status:  new => needs_review


Comment:

 Ok, I lucked out and got ahold of a 64bit macbook with Xcode on it today.
 I ran several builds dropping various Firefox patches and eventually found
 the bug. It was actually in a helper API that affected *both* the image
 cache isolation patch and the DOM storage patch. I pushed a fix that
 stopped the twitter crashes for me to mikeperry/bug3944-intlfixes, head
 commit hash of that branch is now
 f0de0fda7b08f15f9fb99ad0831596c16f77d3f7.

 Setting this as "needs review" for someone to try building with the patch
 and reproduce the lack of crashes. I definitely fixed a crash bug (it was
 a refcount issue that basically lead to a use-after-free), but who knows
 if there are still more. Though, I didn't experience any at least.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8234#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online