[tor-bugs] #8208 [Tor]: Avoid crash if extrainfo generation fails

[Tor Bug Tracker & Wiki]

#8208: Avoid crash if extrainfo generation fails
------------------------------------+---------------------------------------
 Reporter:  nickm                   |          Owner:                    
     Type:  defect                  |         Status:  new               
 Priority:  normal                  |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                     |        Version:                    
 Keywords:  tor-relay 023-backport  |         Parent:                    
   Points:                          |   Actualpoints:                    
------------------------------------+---------------------------------------
 If we fail to generate an extrainfo (can that happen?) we go on generating
 a routerinfo, but later in router_rebuild_descriptor() we do:

 {{{
   if (options->BridgeRelay) {
     /* Bridges shouldn't be able to send their descriptors unencrypted,
        anyway, since they don't have a DirPort, and always connect to the
        bridge authority anonymously.  But just in case they somehow think
 of
        sending them on an unencrypted connection, don't allow them to try.
 */
     ri->cache_info.send_unencrypted = ei->cache_info.send_unencrypted = 0;
   } else {
     ri->cache_info.send_unencrypted = ei->cache_info.send_unencrypted = 1;
   }
 }}}

 note the unconditional assignment to a field of ei.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8208>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online