[tor-bugs] #8049 [Stem]: Stem's DescriptorReader misses 10% of descriptors in tarballs

[Tor Bug Tracker & Wiki]

#8049: Stem's DescriptorReader misses 10% of descriptors in tarballs
---------------------+------------------------------------------------------
 Reporter:  karsten  |          Owner:  atagar  
     Type:  defect   |         Status:  assigned
 Priority:  normal   |      Milestone:          
Component:  Stem     |        Version:          
 Keywords:           |         Parent:          
   Points:           |   Actualpoints:          
---------------------+------------------------------------------------------

Comment(by karsten):

 Nice catch!

 I wonder if I should make metrics-db/-lib stricter when it comes to
 malformed descriptors.  Right now, they don't consider this descriptor
 malformed, because there are no malformed arguments in a known-keyword
 line.  They consider "?contact" (with ? being those non-ASCII bytes) an
 unknown keyword, and unknown keywords are allowed.  I guess I could
 require

 {{{
 KeywordChar ::= 'A' ... 'Z' | 'a' ... 'z' | '0' ... '9' | '-'
 }}}

 The result would be that this descriptor is malformed, not just that it
 contains an unrecognized line.  Does that make sense?  How will Stem
 handle this?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8049#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online