[tor-bugs] #8171 [Flashproxy]: Facilitator tells proxies how often to poll

[Tor Bug Tracker & Wiki]

#8171: Facilitator tells proxies how often to poll
-------------------------+--------------------------------------------------
 Reporter:  dcf          |          Owner:  aallai        
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Flashproxy   |        Version:                
 Keywords:               |         Parent:  #8172         
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by dcf):

  * status:  needs_review => needs_revision


Comment:

 Good work on this. It's almost ready.

 Don't make it an error in `get_reg` if the facilitator doesn't send
 `CHECK-BACK-IN`. It shouldn't be required. `facilitator.cgi` should cope
 with this situation by not sending back a `check-back-in` value.

 Process the value in `flashproxy.js` with `get_param_integer`, not
 `get_param_timespec`.

 Declare the local var `poll_interval`.

 I want `facilitator_poll_interval` to override what the facilitator says
 in all cases. The global `facilitator_poll_interval` should not change
 once initialized.
 {{{
 if facilitator_poll_interval, use that
 elseif check-back-in, use that
 else use DEFAULT_FACILITATOR_POLL_INTERVAL
 }}}
 In all the above cases, take the max of what you decide and
 `MIN_FACILITATOR_POLL_INTERVAL`.

 Bump DEFAULT_FACILITATOR_POLL_INTERVAL up to 1 hour--that case shouldn't
 happen unless there's a problem somewhere. Increase
 MIN_FACILITATOR_POLL_INTERVAL to 10 seconds.

 If the proxy gets a nonsense `check-back-in` (`get_param_integer` returns
 `null`), log the error and fall back to
 `DEFAULT_FACILITATOR_POLL_INTERVAL`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8171#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online