[tor-bugs] #3944 [Tor bundles/installation]: TBB prefs are set as user_prefs (may cause exceptions/settings errors?)

[Tor Bug Tracker & Wiki]

#3944: TBB prefs are set as user_prefs (may cause exceptions/settings errors?)
---------------------------------------+------------------------------------
 Reporter:  mikeperry                  |          Owner:  erinn                        
     Type:  defect                     |         Status:  new                          
 Priority:  major                      |      Milestone:  TorBrowserBundle 2.3.x-stable
Component:  Tor bundles/installation   |        Version:                               
 Keywords:  tbb-bounty, tbb-usability  |         Parent:                               
   Points:                             |   Actualpoints:                               
---------------------------------------+------------------------------------

Comment(by mcs):

 Erinn and Mike -- please review the two patches.  Some details:
 - Our browser.startup.homepage value is now handled like the Firefox
 default value for that pref.  It must come from a properties file so that
 code in Firefox that calls getComplexValue() will work.  And we need to
 change Torbutton to always use getComplexValue() too.

 - The other prefs. are now split between a #tor.js file which is placed in
 the browser application area (named so pref values in it override other
 Firefox default preferences) and a preferences/extension-overrides.js file
 which is placed in the user profile area (necessary in order to override
 default preferences contained within extensions such as NoScript).

 - In windows-alpha.mk, we made a couple of somewhat unrelated changes:
 add /c prefix to MING path and remove some PYMAKE leftovers).  Someone who
 better understands the implications should make sure those changes are
 desirable.

 Also, Kathy and I removed the following preferences which we do not think
 need to be set:
  pref("app.update.lastUpdateTime.addon-background-update-timer",
 1216566538);
  pref("app.update.lastUpdateTime.background-update-timer", 1216566535);
  pref("app.update.lastUpdateTime.blocklist-background-update-timer",
 1216566538);
  pref("app.update.lastUpdateTime.microsummary-generator-update-timer",
 1232574822);
  pref("app.update.lastUpdateTime.search-engine-update-timer", 1216566539);
  pref("urlclassifier.keyupdatetime.https://sb-
 ssl.google.com/safebrowsing/newkey", 1235166825);
  pref("urlclassifier.tableversion.goog-black-enchash", "1.55536");
  pref("urlclassifier.tableversion.goog-black-url", "1.23256");
  pref("urlclassifier.tableversion.goog-white-domain", "1.481");
  pref("urlclassifier.tableversion.goog-white-url", "1.371");

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3944#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online