[tor-bugs] #8011 [Ooni]: add test that can run scripts through an interpreter

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Feb 7 13:50:58 UTC 2013


#8011: add test that can run scripts through an interpreter
-------------------------+--------------------------------------------------
 Reporter:  dma          |          Owner:  isis        
     Type:  enhancement  |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Ooni         |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------

Comment(by hellais):

 Replying to [comment:3 isis]:
 > I was working with dma while they developed this, and watched the
 debugging eventually come out clean. I'll make a dev branch and patch this
 in, test and then send a pull request.

 Has progress been made on this?

 This this code look really good. The only change I would suggest is to
 remove the lines where you check to see if the reactor is running or not
 since when writing tests the assumption is made that the reactor loop will
 be started elsewhere.

 It is not wrong to have those lines there, they just will never get
 executed.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8011#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list