[tor-bugs] #10398 [TorBrowserButton]: Please do not create strings untranslatable with Transifex

[Tor Bug Tracker & Wiki]

#10398: Please do not create strings untranslatable with Transifex
----------------------------------+-----------------------
     Reporter:  lunar             |      Owner:  mikeperry
         Type:  defect            |     Status:  new
     Priority:  normal            |  Milestone:
    Component:  TorBrowserButton  |    Version:
   Resolution:                    |   Keywords:
Actual Points:                    |  Parent ID:
       Points:                    |
----------------------------------+-----------------------

Comment (by lunar):

 You should invalidate them anyway:

 {{{
 torbutton$ git grep beforeLink.label -- src/chrome/locale | grep -vE
 '(with|Search)'
 src/chrome/locale/de/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "Suche">
 src/chrome/locale/de/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "Suche">
 src/chrome/locale/de/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "mit">
 src/chrome/locale/de/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "mit">
 src/chrome/locale/es/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "Busque">
 src/chrome/locale/es/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "Busque">
 src/chrome/locale/es/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "con">
 src/chrome/locale/es/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "con">
 src/chrome/locale/fa/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "جستجو">
 src/chrome/locale/fa/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "جستجو">
 src/chrome/locale/fa/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "">
 src/chrome/locale/fa/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "">
 src/chrome/locale/fr/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "Rechercher">
 src/chrome/locale/fr/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "Rechercher">
 src/chrome/locale/fr/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "avec">
 src/chrome/locale/fr/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "avec">
 src/chrome/locale/it/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "Cerca">
 src/chrome/locale/it/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "Cerca">
 src/chrome/locale/it/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "con">
 src/chrome/locale/it/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "con">
 src/chrome/locale/ja/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "検索">
 src/chrome/locale/ja/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "検索">
 src/chrome/locale/ja/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "一緒に">
 src/chrome/locale/ja/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "一緒に">
 src/chrome/locale/ko/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "">
 src/chrome/locale/ko/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "">
 src/chrome/locale/ko/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "">
 src/chrome/locale/ko/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "">
 src/chrome/locale/nl/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "Zoeken">
 src/chrome/locale/nl/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "Zoeken">
 src/chrome/locale/nl/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "met">
 src/chrome/locale/nl/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "met">
 src/chrome/locale/pl/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "Szukaj">
 src/chrome/locale/pl/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "Szukaj">
 src/chrome/locale/pl/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "z">
 src/chrome/locale/pl/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "z">
 src/chrome/locale/pt/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "Procurar">
 src/chrome/locale/pt/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "Procurar">
 src/chrome/locale/pt/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "com">
 src/chrome/locale/pt/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "com">
 src/chrome/locale/ru/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "Поиск">
 src/chrome/locale/ru/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "Поиск">
 src/chrome/locale/vi/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "">
 src/chrome/locale/vi/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "">
 src/chrome/locale/vi/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "">
 src/chrome/locale/vi/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "">
 src/chrome/locale/zh-CN/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.privacy.beforeLink.label "搜索">
 src/chrome/locale/zh-CN/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.privacy.beforeLink.label "搜索">
 src/chrome/locale/zh-CN/aboutTor.dtd:<!ENTITY
 aboutTor.searchSP.search.beforeLink.label "引擎">
 src/chrome/locale/zh-CN/aboutTor.dtd:<!ENTITY
 aboutTor.searchDDG.search.beforeLink.label "引擎">
 }}}

 They are all missing the spaces.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10398#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online