[tor-bugs] #5851 [BridgeDB]: Make BridgeDB's output compatible with both Vidalia & TorLauncher

[Tor Bug Tracker & Wiki]

#5851: Make BridgeDB's output compatible with both Vidalia & TorLauncher
-------------------------+-------------------------------------------------
     Reporter:  runa     |      Owner:  isis
         Type:           |     Status:  closed
  enhancement            |  Milestone:
     Priority:  major    |    Version:
    Component:           |   Keywords:  bridgedb-email,bridgedb-dist,
  BridgeDB               |  bridgedb-ui
   Resolution:  fixed    |  Parent ID:  #9156
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by isis):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Since TBB-3.5 is about to be released, Vidalia will be deprecated. I think
 we should no longer try to support both Vidalia and TorLauncher
 simultaneously; we should only support up-to-date TBBs and tell users
 running Vidalia to switch.

 Open question, likely for a new ticket if anyone cares: ''Will this cause
 trouble for TAILS users?'' Since TorLauncher can handle bridge lines
 regardless of whether or not they are prefixed with `"bridge "`, we can
 still leave them out as we are currently. (Or add them back in, if somehow
 that makes it easier for TAILS users.)

 For the record:
  * The `"bridge "` prefix was removed from regular bridge lines in commit
 792cfd99bb3a4
  * The `"bridge "` prefix was removed from PT lines in commit 20d6171844d
  * Three failing unittests from the old tests in `lib/bridgebd/Tests.py`
 were failing due to these changes, and these unittests were fixed in
 commit 514e93753dd3

 I am closing this ticket, for the following reasons:
  * We are about to no longer support Vidalia and TBB-2.x
  * We are about to deprecate Vidalia entirely
  * Vidalia doesn't handle bridge fingerprints correctly (see #9499)
  * Vidalia doesn't handle PTs correctly
  * Vidalia doesn't handle PT shared secrets correctly

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5851#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online