[tor-bugs] #10342 [Obfsproxy]: make Circuit param a class attribute of Transport, instead of a per-method param

[Tor Bug Tracker & Wiki]

#10342: make Circuit param a class attribute of Transport, instead of a per-method
param
-----------------------+---------------------------
 Reporter:  infinity0  |          Owner:  infinity0
     Type:  defect     |         Status:  new
 Priority:  normal     |      Milestone:
Component:  Obfsproxy  |        Version:
 Keywords:             |  Actual Points:
Parent ID:             |         Points:
-----------------------+---------------------------
 19:47:13 <asn> still one transport instance per incoming connection
 [..]
 19:47:41 <infinity0> it's just having circuit as a separate parameter
 makes it look like you might have multiple
 19:47:56 <asn> separate parameter of what?
 19:48:03 <infinity0> of the received* methods
 [..]
 19:48:14 <asn> you are right
 19:48:20 <asn> also david415 mentioned that.
 19:48:28 <infinity0> ah
 19:48:38 <asn> i would accept a patch that makes circuit an element of the
 transport class


 One of doing this would be, in BaseTransport, define `handshake` to do
 `self.circuit = circuit`. Possibly also rename `handshake` to
 `circuitConnected`, since it is a callback and you don't necessarily
 *need* to do a handshake.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10342>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online