[tor-bugs] #9462 [BridgeDB]: BridgeDB descriptor parsers need refactoring

[Tor Bug Tracker & Wiki]

#9462: BridgeDB descriptor parsers need refactoring
-------------------------+-------------------------------------------------
     Reporter:  isis     |      Owner:  isis
         Type:  task     |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:           |    Version:
  BridgeDB               |   Keywords:  descriptors,tor-
   Resolution:           |  bridge,bridgedb,refactoring
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by isis):

 * status:  accepted => needs_review


Comment:

 Another branch for this ticket,
 [https://gitweb.torproject.org/user/isis/bridgedb.git/shortlog/refs/heads/fix/9462
 -refactor-netstatus-parsers_rdevelop fix/9462-refactor-netstatus-
 parsers_rdevelop], adds unittests [https://coveralls.io/files/97600616
 with 100% coverage for networkstatus.py] and fixes for
 `bridgedb.parse.networkstatus`.

 It was [https://travis-ci.org/isislovecruft/bridgedb/builds/15107473
 tested here] (rebased on top of my `develop` branch) and it passes.

 And it was also [https://travis-
 ci.org/isislovecruft/bridgedb/builds/15107945 tested again] (rebased on
 top of my `develop` branch plus the
 [https://gitweb.torproject.org/user/isis/bridgedb.git/shortlog/refs/heads/fix
 /9462C-ipaddr-portlist-module fix/9462C-ipaddr-portlist-module] branch
 mentioned in [comment:6 the last comment]) and it also passes. I would
 recommend that this version (the `fix/9462-refactor-netstatus-
 parsers_r9462C` branch) be merged into `develop`, rather than rebasing and
 merging the other two.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9462#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online