[tor-bugs] #10289 [Flashproxy]: "make install" doesn't install flashproxy-common modules

[Tor Bug Tracker & Wiki]

#10289: "make install" doesn't install flashproxy-common modules
----------------------------+-----------------
     Reporter:  dcf         |      Owner:
         Type:  defect      |     Status:  new
     Priority:  minor       |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:
Actual Points:              |  Parent ID:
       Points:              |
----------------------------+-----------------

Comment (by infinity0):

 Replying to [comment:3 dcf]:
 > Replying to [comment:2 infinity0]:
 > > This is intended, so that separate build scripts are responsible for
 installing separate components.
 >
 > That is bogus. The rigid separation of components is helpful for
 packagers and no one else. `make -f Makefile.client install` should give
 me a working installation, not just copy a bunch of useless files.
 >

 I'll add a `make install` target in the top-level normal Makefile. This is
 more appropriate than adding it to Makefile.client.

 > I want to install flashproxy-client to somewhere in my path so that I
 can test obfs-flash-client. What's the procedure to do that?
 >

 In the meantime you can add the appropriate entry to your PATH, or set
 FLASHPROXY_CLIENT when running obfs-flash-client.

 > Why can't installing flashproxy-client also install flashproxy-common
 (and installing facilitator also install flashproxy-common)? Even if there
 are separate makefiles/setup.py for different components, they may call
 each other.

 It's generally not a good idea to handle dependencies within a component,
 otherwise you get the diamond problem. Here, if facilitator /
 Makefile.client installs flashproxy-common automatically, you'll end up
 installing it twice, which might be problematic. It's also not good for
 any overall-packaging scripts (which is the correct place to handle
 dependencies).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10289#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online