[tor-bugs] #10267 [Tor]: [PATCH] Fixed transparent proxy destination lookup on FreeBSD

[Tor Bug Tracker & Wiki]

#10267: [PATCH] Fixed transparent proxy destination lookup on FreeBSD
-----------------------------+--------------------------------
     Reporter:  yurivict     |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------
Changes (by nickm):

 * status:  new => needs_review
 * milestone:   => Tor: 0.2.5.x-final


Comment:

 Marking for inclusion in 0.2.5; 0.2.3 and 0.2.4 are currently in bugfixes-
 only mode.

 Can we do any checks to verify that ipfw is actually in use?  Otherwise,
 getsockname() will succeed, but will give a (presumably local) address.

 The code could be simplified by the use of tor_addr_from_sockaddr().

 In get_pf_socket(), do we really want to keep trying to open /dev/pf every
 time we get an incoming socket?  That seems pretty wasteful.  Maybe we
 should remember that /dev/pf wasn't there.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10267#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online