[tor-bugs] #9199 [BridgeDB]: Rethink the logging of BridgeDB

[Tor Bug Tracker & Wiki]

#9199: Rethink the logging of BridgeDB
--------------------------+----------------------------
     Reporter:  asn       |      Owner:  isis
         Type:  task      |     Status:  needs_revision
     Priority:  normal    |  Milestone:
    Component:  BridgeDB  |    Version:
   Resolution:            |   Keywords:
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+----------------------------

Comment (by isis):

 Just jotting down two more bugs/problems that I've noticed:

  1) At L435 (or thereabouts) in lib/bridgedb/EmailServer.py:
 {{{
 $ ack-grep log | ack-grep body
 lib/bridgedb/EmailServer.py:435:    logging.debug("Email body:\n%s" %
 f.read())
 }}}
 This doesn't actually log the ''body'' of the email, it logs the body of
 the email ''and'' the full headers, including the original client headers,
 which include the client's email address and IP address.

  2) At L207 (ish) in lib/bridgedb/Main.py:
 {{{
 206                 logging.warn("Parsed bridge that we've already added.
 Skipping")
 207                 logging.debug("  Bridge: %s" % bridge.getID())
 }}}
 This is borking the logfiles, because `getID()` returns the raw SHA-1
 digest, not the hex representation (the latter is already stored in
 `bridge.fingerprint`).

 I wasn't sure whether or not to make separate bugs for these, since the
 fixes are only like +6/-2 changes.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9199#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online