[tor-bugs] #9543 [Tor]: weird behaviour when MaxCircuitDirtiness is set to a high value

[Tor Bug Tracker & Wiki]

#9543: weird behaviour when MaxCircuitDirtiness is set to a high value
------------------------+---------------------------------------------------
 Reporter:  ra          |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:  Tor: 0.2.3.25     
 Keywords:  tor-client  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 Patch looks fine.

 Just for my own clarification, the issue is that lines like
 {{{
        circ->timestamp_dirty+get_options()->MaxCircuitDirtiness <= now)
 }}}
 will add circ->timestamp_dirty to MaxCircuitDirtiness, overflow it, get a
 negative number, and say "yes it's less than now"?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9543#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online