[tor-bugs] #9529 [Tor Check]: Replace check.tp.o webservers with Arlo's Go version

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Aug 23 00:49:28 UTC 2013


#9529: Replace check.tp.o webservers with Arlo's Go version
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:     
     Type:  task       |         Status:  new
 Priority:  normal     |      Milestone:     
Component:  Tor Check  |        Version:     
 Keywords:             |         Parent:     
   Points:             |   Actualpoints:     
-----------------------+----------------------------------------------------

Comment(by arlolra):

 > I would be interested in contributing to this if Arlo would like a hand.
 I'm also able to benchmark if needed.

 I'm happy to have the help. Feel free to send pull requests. Some
 benchmarking seems like a great place to start.

 > - Check seems to serve pages which either occasionally change (like
 RecommendedTBBVersions and exit-addresses) or a segment changes based on a
 dns lookup, such as the index page.  The total amount of data here is
 really small. I would try to eliminate disk reads where possible by
 loading these into a buffer and serving them directly from there.  These
 buffers could be reloaded in response to a SIGHUP.

 Agreed. There's already a listener to reload the exit list.
 https://github.com/arlolra/check/blob/master/check.go#L285-L294

 This makes me think we should inline the css file and remove that extra
 request.

 > - Responses should be gzipped to close connections more quickly.

 Yup. check2.torproject.org seems to have gzip enabled already.

 > - I don't think the mutexes around ExitMap are necessary.  The variable
 is only written to in LoadLists.

 Maps in golang aren't thread safe and LoadLists is signalled to run in
 another channel.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9529#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list