[tor-bugs] #9564 [Tor]: Bogus "return" in update_consensus_networkstatus_downloads()

[Tor Bug Tracker & Wiki]

#9564: Bogus "return" in update_consensus_networkstatus_downloads()
-----------------------------------------------+----------------------------
 Reporter:  nickm                              |          Owner:                    
     Type:  defect                             |         Status:  new               
 Priority:  normal                             |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                                |        Version:                    
 Keywords:  tor-client tor-relay 023-backport  |         Parent:                    
   Points:                                     |   Actualpoints:                    
-----------------------------------------------+----------------------------
 In update_consensus_networkstatus_downloads(), we consider, flavor-by-
 flavor, which networkstatus documents if any to download.  If we decide
 not to download one, we should use "continue" to consider the next.
 Instead, in one place, we use return:
 {{{
     if (time_to_download_next_consensus[i] > now)
       return; /* Wait until the current consensus is older. */
 }}}

 This can prevent a directory cache from fetching microdescriptor
 consensuses in a sufficiently timely way.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9564>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online