[tor-bugs] #9543 [Tor]: weird behaviour when MaxCircuitDirtiness is set to a high value

[Tor Bug Tracker & Wiki]

#9543: weird behaviour when MaxCircuitDirtiness is set to a high value
------------------------+---------------------------------------------------
 Reporter:  ra          |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:  Tor: 0.2.3.25     
 Keywords:  tor-client  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * keywords:  => tor-client
  * milestone:  => Tor: 0.2.4.x-final


Comment:

 Yeah, it looks like there are some overflow opportunities with huge
 MaxCircuitDirtiness values.

 Fortunately, they're easy enough to find: every use of MaxCircuitDirtiness
 is in src/or/circuituse.c.

 As I see it, there are two options for a fix: one not too hard, and one
 easier.
    * Fix the code to avoid overflow.
    * Add a maximum value to MaxCircuitDirtiness in config.c.  (See how
 MIN_MAX_CIRCUIT_DIRTINESS is enforced there.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9543#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online